-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate incoming JSON data from pubsub. #29080
Conversation
As well as good practice, not doing so may result in much more obscure errors (e.g. during encoding) downstream.
Codecov Report
@@ Coverage Diff @@
## master #29080 +/- ##
==========================================
- Coverage 38.39% 38.37% -0.02%
==========================================
Files 686 686
Lines 101651 101675 +24
==========================================
- Hits 39025 39021 -4
- Misses 61042 61075 +33
+ Partials 1584 1579 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Thanks. I'm re-generating the requirements files to resolve the merge conflicts. |
As well as good practice, not doing so may result in much more obscure errors (e.g. during encoding) downstream.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.