Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Add optional output type parameter to mappings. #29077

Merged
merged 9 commits into from
Oct 25, 2023

Conversation

robertwb
Copy link
Contributor

This can be useful when inference is insufficient for Python/Javascript.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

R: @Polber

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #29077 (ab245e9) into master (40e5c38) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head ab245e9 differs from pull request most recent head 46a3318. Consider uploading reports for the commit 46a3318 to get more accurate results

@@            Coverage Diff             @@
##           master   #29077      +/-   ##
==========================================
- Coverage   38.38%   38.35%   -0.03%     
==========================================
  Files         686      686              
  Lines      101665   101735      +70     
==========================================
+ Hits        39020    39021       +1     
- Misses      61068    61135      +67     
- Partials     1577     1579       +2     
Flag Coverage Δ
python 29.96% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/transforms/core.py 41.41% <0.00%> (-0.14%) ⬇️
sdks/python/apache_beam/yaml/yaml_mapping.py 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb robertwb merged commit ffb4332 into apache:master Oct 25, 2023
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants