-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log warning when gen_protos is not found #29025
Conversation
7b3a858
to
2d57ac1
Compare
Codecov Report
@@ Coverage Diff @@
## master #29025 +/- ##
==========================================
- Coverage 38.40% 38.39% -0.02%
==========================================
Files 686 686
Lines 101609 101640 +31
==========================================
Hits 39028 39028
- Misses 61001 61032 +31
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2d57ac1
to
34b5f77
Compare
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
34b5f77
to
0abf41f
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
0abf41f
to
e1f1311
Compare
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For internal tests, tar ball is created by copybara and it doesn't include gen_protos.py. In the PR #28385, we provide hard RuntimeError when error originates from gen_protos.py. By pass the error when gen_protos is not found.
FYI, externally built sdist contains gen_protos.py but for internal imports, we don't. Since it is a build time dependency for building proto files, it is not necessary to raise RuntimeError while installing tar ball using
pip install <>.tar.gz
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.