Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warning when gen_protos is not found #29025

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

AnandInguva
Copy link
Contributor

For internal tests, tar ball is created by copybara and it doesn't include gen_protos.py. In the PR #28385, we provide hard RuntimeError when error originates from gen_protos.py. By pass the error when gen_protos is not found.

FYI, externally built sdist contains gen_protos.py but for internal imports, we don't. Since it is a build time dependency for building proto files, it is not necessary to raise RuntimeError while installing tar ball using pip install <>.tar.gz


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #29025 (e02b03c) into master (a6917d4) will decrease coverage by 0.02%.
Report is 10 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #29025      +/-   ##
==========================================
- Coverage   38.40%   38.39%   -0.02%     
==========================================
  Files         686      686              
  Lines      101609   101640      +31     
==========================================
  Hits        39028    39028              
- Misses      61001    61032      +31     
  Partials     1580     1580              
Flag Coverage Δ
python 30.00% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/setup.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@AnandInguva
Copy link
Contributor Author

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@chamikaramj chamikaramj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AnandInguva AnandInguva merged commit bde6005 into apache:master Oct 17, 2023
68 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants