Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency groups in Readme #29021

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix concurrency groups in Readme #29021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ Concurrency groups are a way of making sure that no more than one Actions run is

```
concurrency:
group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login}}'
group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.id || github.event.sender.login }}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damccorm This is actually not quite correct - we keep using the github.event.pull_request.head.label condition but only in case there is a pull_request_target event trigger. For instance, all PreCommit workflows have this event and the condition should be specified (e.g. https://github.com/apache/beam/blob/master/.github/workflows/beam_PreCommit_Go.yml#L50).
I think it makes sense to add a comment bellow describing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreydevyatkin would you mind putting up a PR to do this?

cancel-in-progress: true
```

Expand Down
Loading