Revert "Setup Java 21 container (#28833)"

[damccorm]

This reverts commit e8e3814.

Looks like this is causing publishing snapshots to fail - https://ci-beam.apache.org/job/beam_Publish_Beam_SDK_Snapshots/6269/console

This might be a problem elsewhere (and probably is on GHA, though that's currently busted too - https://github.com/apache/beam/actions/workflows/beam_Publish_Beam_SDK_Snapshots.yml)

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[damccorm]

R: @Abacn

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[codecov]

Codecov Report

Merging #28968 (d71a949) into master (a94d29f) will decrease coverage by 33.79%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #28968       +/-   ##
===========================================
- Coverage   72.17%   38.39%   -33.79%     
===========================================
  Files         686      686               
  Lines      101596   101625       +29     
===========================================
- Hits        73330    39022    -34308     
- Misses      26687    61024    +34337     
  Partials     1579     1579               

Flag	Coverage Δ
go	53.42% <ø> (ø)
python	30.01% <ø> (-52.63%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 311 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[chamikaramj]

LGTM. Thanks.

[Abacn]

I see, that's because Jenkins does not have Java21 installed yet, yes we should revert

[Abacn]

this line causes Jenkins trying to build Java21 container as part of publish SDK snapshot job

[damccorm]

Run SQL PreCommit

[damccorm]

Run Java_Kinesis_IO_Direct PreCommit

[github-actions]

Test Results

  1 275 files  +  1 261    1 275 suites  +1 261   1h 20m 22s ⏱️ - 39m 18s
10 670 tests +10 651  10 602 ✔️ +10 583  68 💤 +68  0 ❌ ±0 
10 694 runs  +10 675  10 626 ✔️ +10 607  68 💤 +68  0 ❌ ±0 

Results for commit d71a949. ± Comparison against base commit a94d29f.

This pull request removes 15 and adds 10666 tests. Note that renamed tests count towards both.

org.apache.beam.examples.complete.AutoCompleteIT ‑ testE2EAutoComplete
org.apache.beam.examples.complete.TfIdfIT ‑ testE2ETfIdf
org.apache.beam.examples.complete.TopWikipediaSessionsIT ‑ testE2ETopWikiPages
org.apache.beam.examples.complete.TrafficMaxLaneFlowIT ‑ testE2ETrafficMaxLaneFlow
org.apache.beam.examples.complete.TrafficRoutesIT ‑ testE2ETrafficRoutes
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2EBigQueryTornadoesWithExport
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2EBigQueryTornadoesWithExportUsingQuery
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2eBigQueryTornadoesWithStorageApi
org.apache.beam.examples.cookbook.BigQueryTornadoesIT ‑ testE2eBigQueryTornadoesWithStorageApiUsingQuery
org.apache.beam.examples.cookbook.CombinePerKeyExamplesIT ‑ testE2ECombinePerKey
…

DefaultPackageTest ‑ defaultPackageInvoker
org.apache.beam.examples.DebuggingWordCountTest ‑ testDebuggingWordCount
org.apache.beam.examples.MinimalWordCountTest ‑ testMinimalWordCount
org.apache.beam.examples.WordCountTest ‑ testCountWords
org.apache.beam.examples.WordCountTest ‑ testExtractWordsFn
org.apache.beam.examples.complete.AutoCompleteTest ‑ testAutoComplete[0]
org.apache.beam.examples.complete.AutoCompleteTest ‑ testAutoComplete[1]
org.apache.beam.examples.complete.AutoCompleteTest ‑ testTinyAutoComplete[0]
org.apache.beam.examples.complete.AutoCompleteTest ‑ testTinyAutoComplete[1]
org.apache.beam.examples.complete.AutoCompleteTest ‑ testWindowedAutoComplete[0]
…

♻️ This comment has been updated with latest results.

[damccorm]

Run Java PreCommit

[damccorm]

Run Java PreCommit

[Abacn]

actually, there is another cause is that the build sdk snapshot task currently always set -Pjava11Home even for Java17.

beam/.test-infra/jenkins/job_Publish_SDK_Image_Snapshots.groovy

Line 53 in 71b8e93

switches("-Pjava11Home=${commonJobProperties.JAVA_11_HOME}")

This worked by coincidence and start failing after the change of #28833

Currently, the JDK used to build java agent for Java17 container is always Java11, actually

[Abacn]

merge for now and will provide a roll forward PR that fixes these issues

[Abacn]

run seed job

[Abacn]

all test passed (except codecov diff report which is not relevant here)