-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Fail WindowInto when there are no inputs to it #28946
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28946 +/- ##
===========================================
- Coverage 72.16% 38.39% -33.78%
===========================================
Files 686 686
Lines 101560 101630 +70
===========================================
- Hits 73294 39017 -34277
- Misses 26687 61034 +34347
Partials 1579 1579
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 312 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python 3.8 PostCommit |
R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
FWIW, I think this should be fixed in the service rather than adding a special case to the SDK (Python only, which won't be out for 6 weeks or so). |
A good place to validate this might be https://github.com/apache/beam/blob/release-2.51.0/sdks/python/apache_beam/runners/common.py#L1895 We could have a mapping of known URNs -> expected input/output cardinality (if any), and flag violations. (We could ensure the inputs/outputs actually exist.)
|
It has been observed that pipelines get stuck when there are no input PCollections to a beam.WindowInto. No logs are observed in the console and the only option left is to force terminate jobs. This PR catches that case and hard fails the pipeline at submission time.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.