Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dataflow containers #28904

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

ahmedabu98
Copy link
Contributor

Updating to include the dependency updates in #28880

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #28904 (9280257) into master (21f822f) will decrease coverage by 0.01%.
Report is 3 commits behind head on master.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master   #28904      +/-   ##
==========================================
- Coverage   72.16%   72.16%   -0.01%     
==========================================
  Files         686      686              
  Lines      101551   101562      +11     
==========================================
+ Hits        73283    73289       +6     
- Misses      26690    26695       +5     
  Partials     1578     1578              
Flag Coverage Δ
python 82.61% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...hon/apache_beam/runners/dataflow/internal/names.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/pipeline.py 91.75% <85.71%> (-0.10%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 94.01% <50.00%> (-0.22%) ⬇️
sdks/python/apache_beam/transforms/display.py 92.20% <75.00%> (-1.17%) ⬇️
sdks/python/apache_beam/yaml/main.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

./gradlew :sdks:python:container:py38:docker
./gradlew :sdks:python:container:py39:docker
./gradlew :sdks:python:container:py310:docker
./gradlew :sdks:python:container:py311:docker

# Shortcut for building all Python SDKs
./gradlew :sdks:python:container buildAll
./gradlew :sdks:python:container:buildAll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, ./gradlew :sdks:python:container buildAll is not a real command. I suspect the space was by mistake

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the documentation

@ahmedabu98 ahmedabu98 merged commit a859863 into apache:master Oct 10, 2023
76 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants