-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support metric_name as list for perf alert tool #28902
Conversation
5331afc
to
c204ab6
Compare
Codecov Report
@@ Coverage Diff @@
## master #28902 +/- ##
==========================================
- Coverage 38.40% 38.39% -0.01%
==========================================
Files 686 686
Lines 101624 101611 -13
==========================================
- Hits 39025 39011 -14
- Misses 61021 61022 +1
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Support metric name as list Update README Run change point analysis even for PR but don't publish or save data fix tests, lint
addfea3
to
7b12e09
Compare
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
GHA failing tests are passing in Jenkins. |
Support metric_name as list in the config yaml file
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.