Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metric_name as list for perf alert tool #28902

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

AnandInguva
Copy link
Contributor

@AnandInguva AnandInguva commented Oct 9, 2023

Support metric_name as list in the config yaml file


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #28902 (41951f5) into master (8de1465) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #28902      +/-   ##
==========================================
- Coverage   38.40%   38.39%   -0.01%     
==========================================
  Files         686      686              
  Lines      101624   101611      -13     
==========================================
- Hits        39025    39011      -14     
- Misses      61021    61022       +1     
  Partials     1578     1578              
Flag Coverage Δ
python 30.01% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ache_beam/testing/analyzers/perf_analysis_utils.py 0.00% <0.00%> (ø)
...hon/apache_beam/testing/analyzers/perf_analysis.py 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Support metric name as list

Update README

Run change point analysis even for PR but don't publish or save data
fix tests, lint
@AnandInguva AnandInguva marked this pull request as ready for review October 9, 2023 23:37
@AnandInguva
Copy link
Contributor Author

R: @pranavbhandari24

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@pranavbhandari24 pranavbhandari24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@AnandInguva
Copy link
Contributor Author

GHA failing tests are passing in Jenkins.

@AnandInguva AnandInguva merged commit 6758aeb into apache:master Oct 16, 2023
54 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants