Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Avro format for PubSub. #28899

Merged
merged 2 commits into from
Oct 12, 2023
Merged

[YAML] Avro format for PubSub. #28899

merged 2 commits into from
Oct 12, 2023

Conversation

robertwb
Copy link
Contributor

@robertwb robertwb commented Oct 9, 2023


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #28899 (41114a4) into master (ad5c2f5) will decrease coverage by 0.07%.
Report is 19 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #28899      +/-   ##
==========================================
- Coverage   72.24%   72.17%   -0.07%     
==========================================
  Files         685      686       +1     
  Lines      101490   101570      +80     
==========================================
- Hits        73324    73312      -12     
- Misses      26587    26681      +94     
+ Partials     1579     1577       -2     
Flag Coverage Δ
python 82.62% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/yaml/yaml_io.py 74.30% <100.00%> (+3.21%) ⬆️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

def test_read_avro(self):

with beam.Pipeline(options=beam.options.pipeline_options.PipelineOptions(
pickle_library='cloudpickle')) as p:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what fails with default pickler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functions instantiated with eval often have trouble with the default pickler (and dill). These come up from PythonCallableWithSource.

@robertwb robertwb merged commit 9c75db4 into apache:master Oct 12, 2023
77 checks passed
damondouglas pushed a commit to damondouglas/beam that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants