Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add withAppProfileId to BigtableIO Read and Write #28864

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

iht
Copy link
Contributor

@iht iht commented Oct 6, 2023

This adds two new config input options to BigtableIO.Read and BigtableIO.Write so users can set the application profile used by the Bigtable client, without having to use other methods that are now deprecated.

This fixes #28862

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @johnjcasey for label io.
R: @igorbernstein2 for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@johnjcasey
Copy link
Contributor

LGTM, but I'll wait for @igorbernstein2 for Bt expertise

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @robertwb @johnjcasey @igorbernstein2

@johnjcasey johnjcasey merged commit 4e6f10b into apache:master Oct 18, 2023
17 checks passed
@iht iht deleted the app_profile branch October 30, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: BigtableIO does not let users specify application profiles
3 participants