Roll forward "Read API Source v2 (#25392)" fix data loss

[Abacn]

Fixes #26354

This reverts commit 4ce8eed.

setEnableBundling is defunct since added to Beam repo and opt-in it will result in data loss, see #26354. After #26267 the number of sources returned by split is no longer an issue and BigQueryStorageStreamBundleSource is not needed after all.

Please add a meaningful description for your change here

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[Abacn]

The only conflict is on the removal of Experimental annotation on master, giving this diff (+105 −2,863) different from original PR (+2,867 −105)

[Abacn]

R: @ahmedabu98

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

[ahmedabu98]

IIRC the setEnableBundling option was implemented to resolve RPC latency issues (design doc here)

@vachan-shetty is this mode no longer needed?

[Abacn]

Added --enableStorageReadApiV2 pipeline option to replace --enableBundling, tested on both runner v1 and v2:

For TPC-DS 1T dataset, it gives "Read session returned 1954 streams", and all records are read. See the internal gcp project

@vachan-shetty PTAL

[damccorm]

@Abacn @vachan-shetty what are next steps here?

[vachan-shetty]

👍🏽

[Abacn]

R: @ahmedabu98 rebased onto latest master to resolve merge conflict. PTAL

[liferoad]

Can we update CHANGES.md to explain this breaking changes?

[Abacn]

Can we update CHANGES.md to explain this breaking changes?

I thought it is fine to remove it without mention it as last time the addition of --enableBundling wasn't mentioned in CHANGES.md either, and it's not been used. However indeed we should note "setEnableStorageReadApiV2" is experimental and could update CHANGES, will do.

[ahmedabu98]

Should this option be removed entirely?

[Abacn]

The effect of this option is to set the number of stream requested to 0 so the server will decide an appropriate number of read streams (which is Read API source v2). It is preserved for now.

[ahmedabu98]

I see, makes sense

[Abacn]

SpannerChangeStreamOrderedWithinKeyIT.testOrderedWithinKey unrelated flaky test, merging for now