Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner image to 2b20e26bb3b99d8e4f41a3d1d9d2e7080043de5c #28769

Conversation

volatilemolotov
Copy link
Contributor

Updates to the latest image
Fixes: #28768 28768

already applied

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@volatilemolotov
Copy link
Contributor Author

R: @Abacn this is already applied and should fix 28768

@Abacn
Copy link
Contributor

Abacn commented Oct 2, 2023

Thanks, is there a reason that we cannot use latest label?

@github-actions github-actions bot added the build label Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn Abacn merged commit 3bbfa7e into apache:master Oct 2, 2023
2 checks passed
@volatilemolotov
Copy link
Contributor Author

@Abacn Just to clarify about latest. We can but i consider it a bad practice as one cannot know when that might change. Also if we do that and use GKE node scaling we are really vulnerable to having some nodes have old versions while other having never. We can bypass that with always pull but that will incur time penalties so i decided against it.
We can implement it but i think its just not worth it

@volatilemolotov volatilemolotov deleted the update_runner_to_2b20e26bb3b99d8e4f41a3d1d9d2e7080043de5c branch October 3, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing Test]: postgres-service-for-local-dev action configuration issue
2 participants