Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm tests on Python PostCommit #28740

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Sep 29, 2023

This fixes the Python arm postcommit and enables it normally. It does this by forcing the jobs to use custom arm containers. Example passing run - https://github.com/apache/beam/actions/runs/6405410458/job/17387943613


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #28740 (5177fc5) into master (a46bc12) will decrease coverage by 0.01%.
Report is 40 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28740      +/-   ##
==========================================
- Coverage   72.22%   72.22%   -0.01%     
==========================================
  Files         684      684              
  Lines      101241   101230      -11     
==========================================
- Hits        73119    73110       -9     
+ Misses      26544    26542       -2     
  Partials     1578     1578              
Flag Coverage Δ
python 82.76% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm damccorm changed the title WIP: Fix arm tests on Python PostCommit Fix arm tests on Python PostCommit Sep 29, 2023
@damccorm damccorm marked this pull request as ready for review October 4, 2023 15:00
@damccorm
Copy link
Contributor Author

damccorm commented Oct 4, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

Fantastic, thanks, Danny!

@damccorm damccorm merged commit 659b220 into master Oct 4, 2023
80 checks passed
@damccorm damccorm deleted the users/damccorm/armPython branch October 4, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants