-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix arm tests on Python PostCommit #28740
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28740 +/- ##
==========================================
- Coverage 72.22% 72.22% -0.01%
==========================================
Files 684 684
Lines 101241 101230 -11
==========================================
- Hits 73119 73110 -9
+ Misses 26544 26542 -2
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
R: @tvalentyn |
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Fantastic, thanks, Danny! |
This fixes the Python arm postcommit and enables it normally. It does this by forcing the jobs to use custom arm containers. Example passing run - https://github.com/apache/beam/actions/runs/6405410458/job/17387943613
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.