-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for pandas 2.0 #28636
Add support for pandas 2.0 #28636
Conversation
R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #28636 +/- ##
==========================================
- Coverage 38.34% 38.28% -0.07%
==========================================
Files 693 690 -3
Lines 102237 102029 -208
==========================================
- Hits 39199 39058 -141
+ Misses 61446 61391 -55
+ Partials 1592 1580 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Seeing an error in coverage suite:
I suspect we need to configure some parquet io tests for pyarrow 4 to use only pandas 1.x; alternatively, we'd have to bump the lower bound for supported pyarrow versions. |
Run Python 3.8 PostCommit |
In postcommits, seeing one relevant error, rest seems flake, need to rerun. �[31mFAILED�[0m apache_beam/examples/dataframe/flight_delays_it_test.py::�[1mFlightDelaysTest::test_flight_delays�[0m - TypeError: Cannot perform reduction 'mean' with string dtype |
Likely some pandas1 code in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/dataframe/flight_delays_it_test.py |
Run Python 3.8 PostCommit |
1 similar comment
Run Python 3.8 PostCommit |
Run Python_Coverage PreCommit |
1 similar comment
Run Python_Coverage PreCommit |
Run Python 3.8 PostCommit |
(running again as the failure should be fixed in #28896) |
@caneff @svetakvsundhar @tvalentyn what are next steps here? |
Run Python_Coverage PreCommit |
Run Python 3.8 PostCommit |
Run Python_PVR_Flink PreCommit |
Run Python_Coverage PreCommit |
Run Python_Coverage Precommit |
Run Python_Runners PreCommit |
|
it seems like something is not right in definition of coverage test suites; I wonder if we don't follow tox.ini syntax correctly |
somehow constraints for different pyarrow versions get conjoined. I wonder if listing pyarrow and pandas on the same line would help. see also: https://stackoverflow.com/questions/57024579/tox-ini-environment-with-multiple-dependencies |
cc94b49
to
2869a6e
Compare
Run Python 3.8 PostCommit |
looks like prior errors are resolved, checking whether remaining apache_beam.utils.multi_process_shared_test.MultiProcessSharedTest.test_connect error is a flake. |
Run Python_Coverage PreCommit |
Noting that Py3.8 have passed on https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/810/ |
Run Python 3.11 PostCommit |
SGTM |
1 similar comment
SGTM |
With all the tests now passing I added a tox config for pandas 2.0, and fixed setup.py and the gradle to support it. Explicitly not supporting 2.1 yet because of an issue I can't figure out (will insert issue number here when I make it).
Fixes #27221