-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run arm suite against all validates_container tests #28627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28627 +/- ##
==========================================
- Coverage 72.20% 71.95% -0.25%
==========================================
Files 684 680 -4
Lines 101131 100163 -968
==========================================
- Hits 73021 72076 -945
+ Misses 26531 26511 -20
+ Partials 1579 1576 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 32 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Run Python_Coverage PreCommit |
R: @tvalentyn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
LGTM. Looks like the only test we are adding atm is sibling_sdk_worker IT test (still a wordcount test; we can remove that test next week). Running all tests could help with future ValCont tests but wouldn't significantly increase coverage now. |
def _run_wordcount_it(self, run_wordcount, **opts): | ||
test_pipeline = TestPipeline(is_integration_test=True) | ||
extra_opts = {} | ||
|
||
if (test_pipeline.get_option('machine_type') == 't2a-standard-1' and | ||
'prebuild_sdk_container_engine' in opts): | ||
pytest.skip('prebuild_sdk_container_engine not supported on ARM') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could mention #28340 in a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
And beam/sdks/python/apache_beam/runners/dataflow/dataflow_exercise_metrics_pipeline_test.py Line 55 in a7e12db
There's also general benefit to reducing the number of distinct suite types we have IMO |
This will give us the same level of confidence that we have with normal python containers.
Example arm tests - https://github.com/apache/beam/actions/runs/6283251262 (including job running on arm)
Example non-arm tests - https://github.com/apache/beam/actions/runs/6283252657 (tougher to pick out a job that definitely was from this run, maybe this one)
2 tests which use
prebuild_sdk_container_engine
don't work (which makes sense), so I special cased them:beam/sdks/python/apache_beam/examples/wordcount_it_test.py
Lines 98 to 105 in 68cf802
We may want to consider supporting that option in the future.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.