Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run arm suite against all validates_container tests #28627

Merged
merged 4 commits into from
Sep 26, 2023

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented Sep 22, 2023

This will give us the same level of confidence that we have with normal python containers.

Example arm tests - https://github.com/apache/beam/actions/runs/6283251262 (including job running on arm)
Example non-arm tests - https://github.com/apache/beam/actions/runs/6283252657 (tougher to pick out a job that definitely was from this run, maybe this one)

2 tests which use prebuild_sdk_container_engine don't work (which makes sense), so I special cased them:

def test_wordcount_it_with_prebuilt_sdk_container_local_docker(self):
self._run_wordcount_it(
wordcount.run,
experiment='beam_fn_api',
prebuild_sdk_container_engine='local_docker')
@pytest.mark.it_validatescontainer
def test_wordcount_it_with_prebuilt_sdk_container_cloud_build(self):

We may want to consider supporting that option in the future.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #28627 (abdcd37) into master (97dea71) will decrease coverage by 0.25%.
Report is 36 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28627      +/-   ##
==========================================
- Coverage   72.20%   71.95%   -0.25%     
==========================================
  Files         684      680       -4     
  Lines      101131   100163     -968     
==========================================
- Hits        73021    72076     -945     
+ Misses      26531    26511      -20     
+ Partials     1579     1576       -3     
Flag Coverage Δ
python 82.53% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damccorm
Copy link
Contributor Author

Run Python_Coverage PreCommit

@damccorm
Copy link
Contributor Author

R: @tvalentyn

@damccorm damccorm marked this pull request as ready for review September 25, 2023 15:02
@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

LGTM. Looks like the only test we are adding atm is sibling_sdk_worker IT test (still a wordcount test; we can remove that test next week). Running all tests could help with future ValCont tests but wouldn't significantly increase coverage now.

def _run_wordcount_it(self, run_wordcount, **opts):
test_pipeline = TestPipeline(is_integration_test=True)
extra_opts = {}

if (test_pipeline.get_option('machine_type') == 't2a-standard-1' and
'prebuild_sdk_container_engine' in opts):
pytest.skip('prebuild_sdk_container_engine not supported on ARM')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could mention #28340 in a comment.

Copy link
Contributor

@tvalentyn tvalentyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@damccorm
Copy link
Contributor Author

damccorm commented Sep 26, 2023

LGTM. Looks like the only test we are adding atm is sibling_sdk_worker IT test (still a wordcount test; we can remove that test next week). Running all tests could help with future ValCont tests but wouldn't significantly increase coverage now.

And

if its not skipped. But yeah, the idea is to knock out the low hanging fruit and then move on to general python postcommit. There's some issues with the normal Python PostCommit suite at the moment, so I'm waiting on those to be fixed before moving forward with that piece.

There's also general benefit to reducing the number of distinct suite types we have IMO

@damccorm damccorm merged commit 57954bd into master Sep 26, 2023
3 checks passed
@damccorm damccorm deleted the users/damccorm/armTests branch September 26, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants