Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated is_categorical calls #28623

Closed
wants to merge 1 commit into from

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Sep 22, 2023

This makes frames_test.py::DeferredFrameTest::test_categorical_groupby fail for AssertionError: NonParallelOperation not raised. Getting rid of the nonparallel=True option in those tests fails with

E       AssertionError: Expression does not preserve partitioning!
E                       Expression: ComputedExpression[post_combine_sum_DataFrame_140482246047888]
E                       Requires: Index
E                       Preserves: Arbitrary
E                       Input partitioning: Index
E                       Expected output partitioning: Index

@caneff
Copy link
Contributor Author

caneff commented Sep 22, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant