Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating access modifiers for utility methods #28511

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Updating access modifiers for utility methods #28511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99eb926
Updating access modifiers for utility methods
Dippatel98 Sep 18, 2023
b29f6f0
Revert "Updating access modifiers for utility methods"
Dippatel98 Sep 18, 2023
59408fa
Updating access modifiers for utility methods
Dippatel98 Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,7 @@ public PCollection<Row> expand(PBegin input) {

// Spotbugs seems to not understand the multi-statement try-with-resources
@SuppressFBWarnings("OBL_UNSATISFIED_OBLIGATION")
private static Schema inferBeamSchema(DataSource ds, String query) {
public static Schema inferBeamSchema(DataSource ds, String query) {
try (Connection conn = ds.getConnection();
PreparedStatement statement =
conn.prepareStatement(
Expand Down
2 changes: 1 addition & 1 deletion sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/SchemaUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ private static ResultSetFieldExtractor createObjectExtractor() {
* A {@link org.apache.beam.sdk.io.jdbc.JdbcIO.RowMapper} implementation that converts JDBC
* results into Beam {@link Row} objects.
*/
static final class BeamRowMapper implements JdbcIO.RowMapper<Row> {
public static final class BeamRowMapper implements JdbcIO.RowMapper<Row> {
private final Schema schema;
private final List<ResultSetFieldExtractor> fieldExtractors;

Expand Down
Loading