Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderRunner cleanup #28496

Merged
merged 8 commits into from
Sep 18, 2023
Merged

RenderRunner cleanup #28496

merged 8 commits into from
Sep 18, 2023

Conversation

hjtran
Copy link
Contributor

@hjtran hjtran commented Sep 18, 2023

While trying to use the RenderRunner, I came across a few warts.

  • It accepts a pipeline proto but doesn't use run_portable_pipeline
  • Not 100% sure about this but it used dotX instead of dot for one of its subprocess calls
  • RenderOptions couldn't be used with .view_as because the init-time validation
  • The RenderRunner logging used the root logger instead of the module logger

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@hjtran
Copy link
Contributor Author

hjtran commented Sep 18, 2023

R: @robertwb

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #28496 (7f709e7) into master (38720a3) will increase coverage by 0.03%.
Report is 20 commits behind head on master.
The diff coverage is 35.71%.

❗ Current head 7f709e7 differs from pull request most recent head 90059bd. Consider uploading reports for the commit 90059bd to get more accurate results

@@            Coverage Diff             @@
##           master   #28496      +/-   ##
==========================================
+ Coverage   72.22%   72.25%   +0.03%     
==========================================
  Files         684      684              
  Lines      100856   100854       -2     
==========================================
+ Hits        72846    72877      +31     
+ Misses      26434    26401      -33     
  Partials     1576     1576              
Flag Coverage Δ
python 82.87% <35.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/runners/render.py 48.12% <35.71%> (+1.52%) ⬆️

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this all looks good. dotX was leftover from testing, really glad you caught this before the release was cut.

@robertwb robertwb merged commit 91842e6 into apache:master Sep 18, 2023
72 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants