Add schema-aware text file reading and writing. #28486
Conversation
|
R: @Polber |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28486 +/- ##
=======================================
Coverage 72.22% 72.22%
=======================================
Files 684 684
Lines 100853 100868 +15
=======================================
+ Hits 72840 72854 +14
- Misses 26436 26437 +1
Partials 1577 1577
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| field_names) | ||
| sole_field_name, = field_names | ||
| return pcoll | beam.Map( | ||
| lambda x: str(getattr(x, sole_field_name))) | beam.io.WriteToText(path) |
There was a problem hiding this comment.
Should we take a (required?) file_extension parameter as well? Right now, this will output files like: <path>-<shard_id>, but I'd guess most people will want <path>-<shard_id>.<extension>
There was a problem hiding this comment.
One may want to be able to specify a general suffix, not just an extension, and maybe other sharding parameters (like the shard format). I think we'll want to add this in a consistent way to all file output types. I'm not confident enough as to what that'll look like to get something in right now though, and it is something additive. (I don't think it should be required, but perhaps could see using .txt as a default and having to override it with an empty string to get nothing. TBD)
There was a problem hiding this comment.
but perhaps could see using .txt as a default
That is still technically breaking fwiw (though I think its fine to do at this stage)
One may want to be able to specify a general suffix, not just an extension, and maybe other sharding parameters (like the shard format). I think we'll want to add this in a consistent way to all file output types. I'm not confident enough as to what that'll look like to get something in right now though, and it is something additive.
I generally agree, though I think I am very confident we will want to allow folks to specify a suffix or extension (naming it suffix instead of extension is fine, though I think the latter is more intuitive for a potentially less technical audience).
Regardless, I am ok leaving this for now since I think getting something before the cut is worthwhile
| # TODO(yaml): Consider passing the filename and offset, possibly even | ||
| # by default. |
There was a problem hiding this comment.
To be clear, you're saying pass them as fields in the returned beam.Row? I'm +1 on optionally doing that in the future FWIW (it would maybe be generally useful for ReadFromText) - in particular, getting the filename would likely be helpful in some use cases
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.