Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dropLataData in GBK for SamzaRunner #28461

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

xinyuiscool
Copy link
Contributor

This patch adds the DoFnRunners.lateDataDroppingRunner() in SamzaRunner GroupByKey translation so we allow users to drop late data in windowing when needed. Also add a boolean flag in SamzaPipelineOptions to turn it on/off.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Test Results

  1 269 files  +  1 262    1 269 suites  +1 262   1h 35m 40s ⏱️ + 1h 31m 29s
10 612 tests +10 570  10 544 ✔️ +10 502  68 💤 +68  0 ±0 
10 636 runs  +10 594  10 568 ✔️ +10 526  68 💤 +68  0 ±0 

Results for commit 160fdf5. ± Comparison against base commit ec422db.

This pull request removes 42 and adds 10612 tests. Note that renamed tests count towards both.
org.apache.beam.sdk.io.hbase.HBaseCoderProviderRegistrarTest ‑ testMutationCoderIsRegistered
org.apache.beam.sdk.io.hbase.HBaseCoderProviderRegistrarTest ‑ testResultCoderIsRegistered
org.apache.beam.sdk.io.hbase.HBaseCoderProviderRegistrarTest ‑ testRowMutationsCoderIsRegistered
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadBuildsCorrectly
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadBuildsCorrectlyInDifferentOrder
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReading
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingDisplayData
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingEmptyTable
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingFailsTableDoesNotExist
org.apache.beam.sdk.io.hbase.HBaseIOTest ‑ testReadingKeyRangeMiddle
…
DefaultPackageTest ‑ defaultPackageInvoker
org.apache.beam.examples.DebuggingWordCountTest ‑ testDebuggingWordCount
org.apache.beam.examples.MinimalWordCountTest ‑ testMinimalWordCount
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchDynamicSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInBatchStaticSharding
org.apache.beam.examples.WindowedWordCountIT ‑ testWindowedWordCountInStreamingStaticSharding
org.apache.beam.examples.WordCountIT ‑ testE2EWordCount
org.apache.beam.examples.WordCountTest ‑ testCountWords
org.apache.beam.examples.WordCountTest ‑ testExtractWordsFn
org.apache.beam.examples.complete.AutoCompleteTest ‑ testAutoComplete[0]
…

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@xinyuiscool xinyuiscool merged commit 67a9cf3 into apache:master Sep 15, 2023
13 checks passed
xinyuiscool added a commit to linkedin/beam that referenced this pull request Sep 15, 2023
ajothomas added a commit to linkedin/beam that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants