Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28187] Prism docker env support. #28444

Merged
merged 10 commits into from
Sep 15, 2023
Merged

[#28187] Prism docker env support. #28444

merged 10 commits into from
Sep 15, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Sep 14, 2023

Enable support for using docker containers with prism.

  • Artifact service is current all In Memory, rather than a local file cache.
  • Artifact service is going to be global for a given instance, ultimately.
  • Docker is orchestrated with client API instead of command line tool.

Part of #28187


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #28444 (99514a6) into master (9c55dae) will decrease coverage by 0.10%.
Report is 113 commits behind head on master.
The diff coverage is 25.58%.

@@            Coverage Diff             @@
##           master   #28444      +/-   ##
==========================================
- Coverage   72.33%   72.23%   -0.10%     
==========================================
  Files         681      682       +1     
  Lines      100355   100515     +160     
==========================================
+ Hits        72589    72608      +19     
- Misses      26192    26330     +138     
- Partials     1574     1577       +3     
Flag Coverage Δ
go 53.42% <25.58%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go 58.86% <0.00%> (ø)
...eam/runners/prism/internal/jobservices/artifact.go 0.00% <0.00%> (ø)
...pkg/beam/runners/prism/internal/jobservices/job.go 64.17% <0.00%> (-4.08%) ⬇️
...s/go/pkg/beam/runners/universal/runnerlib/stage.go 40.47% <0.00%> (ø)
...o/pkg/beam/runners/prism/internal/worker/worker.go 44.50% <10.00%> (-0.45%) ⬇️
...go/pkg/beam/runners/prism/internal/environments.go 29.49% <29.49%> (ø)
sdks/go/pkg/beam/runners/prism/internal/execute.go 85.08% <45.45%> (-1.99%) ⬇️
...m/runners/prism/internal/jobservices/management.go 55.36% <100.00%> (+0.38%) ⬆️
.../beam/runners/prism/internal/jobservices/server.go 92.59% <100.00%> (+0.28%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@lostluck
Copy link
Contributor Author

Ah dang it. This is not yet ready. Please disregard.

@lostluck
Copy link
Contributor Author

lostluck commented Sep 15, 2023

R: @jrmccluskey

This should be OK to look at now.

I could make the artifact handling more robust (and not a memory leak), or even set up "prism runner w/container" runs as a pre commit, but I think I'd like those as separate PRs.

I don't love the current test coverage, but it seems tricky to do for the time being, and that gets covered by adding the full suite runs.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey jrmccluskey merged commit a0f14a8 into master Sep 15, 2023
@lostluck lostluck changed the title Prism docker env [#28187] Prism docker env support. Sep 15, 2023
@lostluck lostluck deleted the prismDockerEnv branch September 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants