Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix flaky test StreamingDataflowWorkerTest" #28434

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 13, 2023

Reverts #28173

The enabled test has been flaky on both Jenkins and actions. e,g, https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/7319/testReport/junit/org.apache.beam.runners.dataflow.worker/StreamingDataflowWorkerTest/testMaxThreadMetric_0___streamingEngine_false__/

and the commit trigger seeing this quite often: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/

Stacktrace
java.lang.AssertionError: expected:<1000> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest.testMaxThreadMetric(StreamingDataflowWorkerTest.java:2935)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@Abacn
Copy link
Contributor Author

Abacn commented Sep 13, 2023

R: @tvalentyn
CC: @olalamichelle thanks willing to dig into this in the original PR. The branch hash is stay so we can always come back and investigate. For now I would propose this change to de-noise purpose

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@tvalentyn
Copy link
Contributor

LGTM, thanks. Sorry about the noise it caused.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 13, 2023

Ironically the PreCommit GitHub Action still fails this test even it's reverted in this PR: https://github.com/apache/beam/actions/runs/6174695355/job/16759856184?pr=28434


> Task :runners:google-cloud-dataflow-java:worker:test

org.apache.beam.runners.dataflow.worker.StreamingDataflowWorkerTest > testMaxThreadMetric[0: [streamingEngine=false]] FAILED
    java.lang.AssertionError at StreamingDataflowWorkerTest.java:2935

@Abacn Abacn merged commit 647704e into master Sep 13, 2023
@Abacn Abacn deleted the revert-28173-issue-72555-2 branch September 13, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants