Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Jenkins Python Formatter PreCommit #28427

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 12, 2023

Address #28426

This PR shutdowns the following Jenkins suite. Their GitHub Actions are in healthy state. And they do not rely on test report (Jenkins Go and TypeScript tests did not have test report either)

Name Jenkins status GitHub Action status
PreCommit_PythonFormatter Build Status .github/workflows/beam_PreCommit_PythonFormatter.yml
PreCommit_Kotlin_Examples Build Status .github/workflows/beam_PreCommit_Kotlin_Examples.yml
PreCommit_Go Build Status .github/workflows/beam_PreCommit_Go.yml
PreCommit_GoPortable Build Status .github/workflows/beam_PreCommit_GoPortable.yml
PreCommit_TypeScript Build Status .github/workflows/beam_PreCommit_Typescript.yml
PreCommit_CommunityMetrics Build Status .github/workflows/beam_PreCommit_CommunityMetrics.yml

For convenience we should merge them into one. Either test does not take long to run.

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2023

@Abacn
Copy link
Contributor Author

Abacn commented Sep 12, 2023

R: @damccorm

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@damccorm
Copy link
Contributor

I'm not sure I see the advantage of doing this; personally I actually like getting a more specific signal for failure and this also lengthens the time to get the signal (which can be important for first-time folks who aren't familiar with our build system and rely on precommits)

@Abacn Abacn changed the title Combine Python Lint and Formatter PreCommit Remove Jenkins Python Formatter PreCommit Sep 14, 2023
@github-actions github-actions bot removed the build label Sep 14, 2023
@Abacn Abacn marked this pull request as draft September 14, 2023 18:56
@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2023

Run Java_HBase_IO_Direct PreCommit - test purpose, to see if the test result plugin can comment on PR

Update: https://github.com/apache/beam/actions/runs/6189896697/job/16804969364 completed though it does not get updated to PR.

There is a log in action.

2023-09-14 19:19:35 +0000 - publish -  INFO - There is no pull request for commit ec422dbfd217218554ad5f0cbf28716930470fed

Wondering if there is a way to assign PR number so make it comment to PR

@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2023

Run Java_HBase_IO_Direct PreCommit

@Abacn Abacn marked this pull request as ready for review September 14, 2023 19:16
@Abacn
Copy link
Contributor Author

Abacn commented Sep 14, 2023

R: @damccorm

PreCommits that does not rely on test report (Java/Python) should be done after this PR. Then I will check if the test report plugin works well / do adjustments / asks for feedback then proceed to shutdown java precommits

Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks!

@Abacn Abacn merged commit 65fc174 into apache:master Sep 14, 2023
3 checks passed
@Abacn Abacn deleted the mergeformatter branch September 14, 2023 19:36
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants