-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Jenkins Python Formatter PreCommit #28427
Conversation
Run PythonLint PreCommit https://github.com/apache/beam/actions/runs/6164792408/job/16731292436 |
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
I'm not sure I see the advantage of doing this; personally I actually like getting a more specific signal for failure and this also lengthens the time to get the signal (which can be important for first-time folks who aren't familiar with our build system and rely on precommits) |
Run Java_HBase_IO_Direct PreCommit - test purpose, to see if the test result plugin can comment on PR Update: https://github.com/apache/beam/actions/runs/6189896697/job/16804969364 completed though it does not get updated to PR. There is a log in action.
Wondering if there is a way to assign PR number so make it comment to PR |
61bc3d7
to
fa9d992
Compare
Run Java_HBase_IO_Direct PreCommit |
R: @damccorm PreCommits that does not rely on test report (Java/Python) should be done after this PR. Then I will check if the test report plugin works well / do adjustments / asks for feedback then proceed to shutdown java precommits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks!
Address #28426
This PR shutdowns the following Jenkins suite. Their GitHub Actions are in healthy state. And they do not rely on test report (Jenkins Go and TypeScript tests did not have test report either)
For convenience we should merge them into one. Either test does not take long to run.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.