Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove level and errors arguments for Pandas 2 compatibility. #28375

Merged
merged 23 commits into from
Sep 13, 2023

Conversation

caneff
Copy link
Contributor

@caneff caneff commented Sep 8, 2023

Use the new removed_args functionality for these.

Partially fixing #27221

Level was always NotImplemented anyway, and errors I conditionally disable based on the pandas version to keep functionality.
@github-actions github-actions bot added the python label Sep 8, 2023
@caneff caneff changed the title Remove level and errors arguments for Pandas 2 compatibility. Level was always NotImplemented anyway, and errors I conditionally disable based on the pandas version to keep functionality. Remove level and errors arguments for Pandas 2 compatibility. Sep 8, 2023
@caneff
Copy link
Contributor Author

caneff commented Sep 8, 2023

R: @tvalentyn

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #28375 (308a790) into master (cf0cf3b) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 85.10%.

@@            Coverage Diff             @@
##           master   #28375      +/-   ##
==========================================
- Coverage   72.32%   72.30%   -0.02%     
==========================================
  Files         683      683              
  Lines      100620   100638      +18     
==========================================
- Hits        72776    72770       -6     
- Misses      26266    26290      +24     
  Partials     1578     1578              
Flag Coverage Δ
python 82.81% <85.10%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sdks/python/apache_beam/dataframe/frame_base.py 89.25% <83.33%> (-0.34%) ⬇️
sdks/python/apache_beam/dataframe/frames.py 95.37% <86.95%> (+0.04%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

caneff and others added 2 commits September 11, 2023 10:48
Pandas removed .append in 2.0 so this helps keep the API consistent.
@caneff caneff requested a review from tvalentyn September 12, 2023 14:55
@tvalentyn tvalentyn merged commit bdf67e8 into apache:master Sep 13, 2023
77 checks passed
@caneff caneff deleted the errors_level3 branch September 14, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants