Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28187][prism] worker shutdown, cleanup, log fail, port spec, grpc recv size #28184

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 28, 2023

Some fixes while trying to use the experimental Swift SDK against prism.

  • Use an actual loopback address for endpoints instead of the net package listener default of unspecified.
    • IPv6 uses "[::]" to mean an unspecified address, which Go then treats as the loopback address. This isn't true across all SDKs, so we must explicitly indicate the loopback address.
    • Note: We create the server to listen to any traffic to that port however, so other connections, possibly off the machine, remain valid.
  • Increase default receive buffer to max.
  • Fail jobs if the SDK worker doesn't connect after 1 minute.
  • Error job failures on log on slog side.
  • Minor log clean up, to a debug log.

Related to #28187


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #28184 (185636c) into master (45ea758) will decrease coverage by 0.02%.
The diff coverage is 47.82%.

@@            Coverage Diff             @@
##           master   #28184      +/-   ##
==========================================
- Coverage   72.30%   72.29%   -0.02%     
==========================================
  Files         678      678              
  Lines       99848    99862      +14     
==========================================
- Hits        72200    72192       -8     
- Misses      26069    26093      +24     
+ Partials     1579     1577       -2     
Flag Coverage Δ
go 53.60% <47.82%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...pkg/beam/runners/prism/internal/jobservices/job.go 66.10% <0.00%> (-1.14%) ⬇️
sdks/go/pkg/beam/runners/prism/internal/execute.go 85.54% <12.50%> (-2.58%) ⬇️
...o/pkg/beam/runners/prism/internal/worker/worker.go 48.55% <63.63%> (+0.17%) ⬆️
.../beam/runners/prism/internal/jobservices/server.go 92.30% <100.00%> (+0.30%) ⬆️
...s/go/pkg/beam/runners/prism/internal/preprocess.go 94.67% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions github-actions bot added build and removed build labels Aug 28, 2023
@github-actions github-actions bot added build and removed build labels Aug 28, 2023
@lostluck lostluck changed the title [prism] worker shutdown, cleanup, log fail, port spec [prism] worker shutdown, cleanup, log fail, port spec, grpc recv size Aug 28, 2023
@lostluck lostluck changed the title [prism] worker shutdown, cleanup, log fail, port spec, grpc recv size [#28187][prism] worker shutdown, cleanup, log fail, port spec, grpc recv size Aug 28, 2023
Copy link
Contributor

@riteshghorse riteshghorse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@lostluck
Copy link
Contributor Author

Thanks for the review!

@lostluck lostluck merged commit 687ed79 into master Aug 28, 2023
lostluck added a commit to lostluck/beam that referenced this pull request Aug 30, 2023
…grpc recv size (apache#28184)

* [prism] worker shutdown, cleanup, log fail

* Increase prism server receive size to max.
@lostluck lostluck deleted the prismGrace1 branch September 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants