-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[prism] support single external env pipelines. #28083
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28083 +/- ##
==========================================
- Coverage 72.33% 70.85% -1.48%
==========================================
Files 678 861 +183
Lines 99772 105060 +5288
==========================================
+ Hits 72169 74441 +2272
- Misses 26040 29056 +3016
Partials 1563 1563
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 219 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one question
…28111) * support single external env pipelines. * provide clear error message --------- Co-authored-by: lostluck <[email protected]>
* [prism] support single external env pipelines. * provide clear error message --------- Co-authored-by: lostluck <[email protected]>
Prism was hard expecting Go environments, but it should be expecting single external (aka, loopback) environments at this time.
Related to #28187
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.