-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Publish JUnit Test Results Action #28075
Conversation
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
@Abacn could you check or suggest a reviewer ? |
third party action needs apache infra's approval to be able to run. Shall I make a request? Also, if there is a test failure, is it possible to see which test and what is the reason for failure? This is the useful part. A summary of how many test run is already available in the log page, but currently the inconvenience for existing github action workflow is that when there is a test failure, there is no way to see the stack trace. |
Hello @Abacn Thank you for your comment Workflow run Here is the README file for the related github action used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! That really helps!
Let's get this in and see if the workflow also runs on beam repo. Possible need request permission to infra |
As expected. created https://issues.apache.org/jira/browse/INFRA-24950 requesting enabling this action |
Update: the third party workflow is whitelisted. I see a green run: https://github.com/apache/beam/actions/runs/6150041760/job/16687179322 But also there is failing run "Invalid workflow file https://github.com/apache/beam/actions/runs/6151946870/workflow Will keep monitoring |
Also, when we apply this plugin to all other java tests, can we also change the uploaded archive for "JUnit Test Results" from
so it would upload human readable detailed test results on failure.
The current xml is not human readable, and |
Hello @Abacn |
This PR was created to add an action that visualize the results of JUnit tests and adds them to the workflow summary page and the PR page (if the PR exists).
The action requires additional permissions:
pull-requests: write (allow adding the test result to the PR page)
checks: write (allow to add test result to workflow summary page)
issues: write (allow to add the test result in order if the issue was created or it was a comment/push)
Example runs:
Push: https://github.com/magicgoody/beam/actions/runs/5926105477
Pull_request_target: https://github.com/magicgoody/beam/actions/runs/5926531661
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.