Refactor ConvertHelpers in "core" to not depend on Avro #27991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @mosche |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
Run Spotless PreCommit |
mosche
reviewed
Aug 18, 2023
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/ConvertHelpers.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SchemaInformationProvider.java
Show resolved
Hide resolved
aromanenko-dev
force-pushed
the
schema_convert_refactoring
branch
from
c4c4953 to
96f3dfb
Compare
|
retest this please |
mosche
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
LGTM, thanks @aromanenko-dev
You probably have to rebase to get tests to pass, these failures look familiar and should be fixed on master.
|
@mosche Actually, I did rebase it yesterday, right before pushing the latest changes. |
|
I'll merge it since failing tests are not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with hard Avro dependency that was found in #27851
It uses
SchemaInformationProviderinstead now.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.