-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM test suite trigger commands to mass comment script #27982
Conversation
i think we should add commands into a text file for consistency and simplicity; there is |
Codecov Report
@@ Coverage Diff @@
## master #27982 +/- ##
==========================================
+ Coverage 72.33% 72.38% +0.04%
==========================================
Files 680 679 -1
Lines 100263 100112 -151
==========================================
- Hits 72530 72470 -60
+ Misses 26162 26075 -87
+ Partials 1571 1567 -4
Flags with carried forward coverage won't be shown. Click here to find out more. see 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
I think splitting into separate files makes sense. Jenkins triggers can be programatically determined (and we do that to update them as part of our release process) so having a distinct file for them makes management easy |
Run Go PostCommit Dataflow ARM |
''' | ||
Returns all trigger commands that will start PostCommit ARM Github Actions test suites. | ||
''' | ||
arm_trigger_commands = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a comment along the lines of: remove this special case once this script can handle GitHub Actions triggers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or should I just create a github_actions_jobs.txt now instead and move all the trigger commands there? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think leaving it is fine for now (with the comment added). Solving trigger commands for actions is an open question that will need to be solved generally soon anyways
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks! But since there are multiple versions of Java and Python, I also need to adjust the trigger command to "Run Java_Examples_Dataflow_ARM PostCommit 11" "Run Python ValidatesContainer Dataflow ARM 3.8"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should do that as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had one more comment, otherwise LGTM
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Run Go PreCommit |
#28663 (comment) :-) |
Here is the console output for
|
I see the issue, going to fix along with #28665 |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.