Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Compatibility Matrix for Flink Unbounded SDF #27759

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jul 31, 2023

context: #27648 (comment)

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Contributor Author

Abacn commented Jul 31, 2023

change not effective. does the source of data come from elsewhere?

@Abacn Abacn marked this pull request as draft July 31, 2023 19:44
@jrmccluskey
Copy link
Contributor

Weird that the change isn't being reflected on the staged website

* Reflecting test result that portable runner support missing
@Abacn
Copy link
Contributor Author

Abacn commented Jul 31, 2023

It appears there are two yml files, and the website uses the other

@jrmccluskey
Copy link
Contributor

Should we consider consolidating those two files?

@Abacn
Copy link
Contributor Author

Abacn commented Jul 31, 2023

Should we consider consolidating those two files?

Probably should. I do not have context why there are two yml at the first place. From the naming it looks like one is for released version and another for dev snapshot. There was a task of generating compatibility matrix automatically by running validate runner tests: https://issues.apache.org/jira/browse/BEAM-2888 and attempted in #22930, https://gist.github.com/alive2020/b7c63851c30c1bb739994a8132aa1fc7 possibly related

@Abacn Abacn marked this pull request as ready for review August 1, 2023 00:09
@Abacn
Copy link
Contributor Author

Abacn commented Aug 1, 2023

Thanks @jrmccluskey now it works PTAL

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey jrmccluskey merged commit 8956343 into apache:master Aug 1, 2023
@Abacn Abacn deleted the updatecompmat branch August 1, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants