Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] V2.47.0 rc3 validations #26563

Closed

Conversation

jrmccluskey
Copy link
Contributor

Dummy PR for RC3 validations


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@jrmccluskey
Copy link
Contributor Author

Run Python ReleaseCandidate

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #26563 (8e821bf) into release-2.47.0 (0b1b073) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           release-2.47.0   #26563      +/-   ##
==================================================
- Coverage           71.17%   71.16%   -0.01%     
==================================================
  Files                 787      787              
  Lines              103294   103311      +17     
==================================================
+ Hits                73518    73526       +8     
- Misses              28287    28296       +9     
  Partials             1489     1489              
Flag Coverage Δ
go 53.67% <ø> (ø)
python 79.85% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/version.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label python.
R: @riteshghorse for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor Author

Run Python Dataflow V2 ValidatesRunner

@jrmccluskey
Copy link
Contributor Author

stop reviewer notifications

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Stopping reviewer notifications for this pull request: requested by reviewer

@jrmccluskey
Copy link
Contributor Author

Run Python Dataflow V2 ValidatesRunner

@tvalentyn
Copy link
Contributor

Run Java PreCommit

@tvalentyn
Copy link
Contributor

Run Java_IOs_Direct PreCommit

1 similar comment
@tvalentyn
Copy link
Contributor

Run Java_IOs_Direct PreCommit

@tvalentyn
Copy link
Contributor

Run RAT PreCommit

@tvalentyn
Copy link
Contributor

Run Website PreCommit

@tvalentyn
Copy link
Contributor

Run Website_Stage_GCS PreCommit

@tvalentyn
Copy link
Contributor

Run Java_Pulsar_IO_Direct PreCommit

1 similar comment
@jrmccluskey
Copy link
Contributor Author

Run Java_Pulsar_IO_Direct PreCommit

@tvalentyn
Copy link
Contributor

tvalentyn commented May 10, 2023

Python SDK Release Candidates Validation

verified streaming wordcount manually on py3.11.

RAT ("Run RAT PreCommit")

looks like this will always fail if we touch an empty file. sounds like empty file needs a licensce too.

Java_Pulsar_IO_Direct ("Run Java_Pulsar_IO_Direct PreCommit") — Build finished.

Looks permared on the branch? did someone weigh in on whether this is blocking or not? FWIW came across #26618

@jrmccluskey
Copy link
Contributor Author

@tvalenyn the test suite passes on the release branch running locally (same environment I rebuilt containers on) so I don't think it's a release blocker.

@tvalentyn
Copy link
Contributor

Run Java_Pulsar_IO_Direct PreCommit

looks like this passed on an earlier RC, so maybe a frequent flake? takes 1 min to run though, so...

@tvalentyn
Copy link
Contributor

Run Java_Pulsar_IO_Direct PreCommit

@jrmccluskey
Copy link
Contributor Author

Build passed, looks like we're good. One last small heart attack before I send out the vote result email

@jrmccluskey jrmccluskey deleted the v2.47.0-RC3_validations branch July 11, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants