Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetricsContainer support to the Flink sources. #25753

Closed
wants to merge 1 commit into from

Conversation

becketqin
Copy link
Contributor

This patch is a follow-up patch for the Flink runner migration from DataSet API to DataStream API. It adds support for MetricsContainer which exposes the metrics defined in Beam metrics via the Flink metric framework.

fixes #25741


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@becketqin
Copy link
Contributor Author

@xinyuiscool Would you help take a look? Thanks!

@becketqin becketqin force-pushed the fix-metrics-container branch from 3a57e31 to 4e383d2 Compare March 8, 2023 01:59
@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@tvalentyn
Copy link
Contributor

@becketqin are you still interested in submitting this change? I'd recommend reaching out on @dev and ask folks who are familiar with FlinkRunner codebase to help take a look.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@github-actions
Copy link
Contributor

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@tvalentyn
Copy link
Contributor

@becketqin are you still interested in submitting this change? I'd recommend reaching out on @dev and ask folks who are familiar with FlinkRunner codebase to help take a look.

ping on this. Thanks!

@jto
Copy link
Contributor

jto commented Sep 21, 2023

Hey there!
Can someone take at look at this PR and #25742 ?
Looks like everything is in place for Beam use DataStream in place of the deprecated DataSet API.
Maybe @xinyuiscool since you reviewed and merged #25525 :)

@tvalentyn
Copy link
Contributor

hey @jto, thanks for reaching out. unfortunately I haven't heard from the original author - if you or someone else can take over the PRs, it might be a path to get the change unblocked. In addition to an author, we will need a reviewer who is familiar with the codebase or is willing to dig in to take more ownership in the flink runner codebase. You could also be a reviewer, then, we will need a committer for the merge but I this point I think we are looking for review to complete. reaching out to dev@ may be an avenue to get help.

@jto
Copy link
Contributor

jto commented Sep 22, 2023

Hey @tvalentyn ! Thanks for your reply. I think either one of my colleague or myself will take over those two PRs :)

@tvalentyn
Copy link
Contributor

Thanks, @jto, let's continue in #28609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add MetricsContainer support in the FLIP-27 sources in Flink runner.
3 participants