[Avro] Use "extensions/avro" instead of avro from"core" in Java SDK modules #24992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aromanenko-dev looking into failing Example check. Sorry for inconvenience ( |
aromanenko-dev
force-pushed
the
avro_24756
branch
from
6740bd3 to
2b74393
Compare
aromanenko-dev
force-pushed
the
avro_24756
branch
from
2b74393 to
b5a65ae
Compare
|
Run Java_Kafka_IO_Direct PreCommit |
aromanenko-dev
force-pushed
the
avro_24756
branch
from
b5a65ae to
420c8bf
Compare
|
Run SQL_Java17 PreCommit |
|
Run Java_GCP_IO_Direct PreCommit |
aromanenko-dev
force-pushed
the
avro_24756
branch
2 times, most recently
from
6bc01d0 to
99ebf96
Compare
|
Run SQL PreCommit |
|
Run SQL_Java11 PreCommit |
|
Run Java_Kafka_IO_Direct PreCommit |
|
Run SQL PreCommit |
|
@Abacn Do you have an idea when it can be fixed? Do you think we have to wait for a fix before merging this one? |
|
Thanks @aromanenko-dev for pinning. I think we can proceed given that those failures are understood to be not related. I also opened #25566 |
|
Run SQL_Java11 PreCommit |
|
Run SQL_Java17 PreCommit |
…le-cloud-platform
aromanenko-dev
force-pushed
the
avro_24756
branch
from
d1c7ef6 to
17b39ac
Compare
aromanenko-dev
force-pushed
the
avro_24756
branch
from
17b39ac to
e9c7c88
Compare
|
retest this please |
|
Run Java_GCP_IO_Direct PreCommit |
|
Run Java_Kafka_IO_Direct PreCommit |
|
Run Java_HCatalog_IO_Direct PreCommit |
|
I merge this one since failed checks are not related and all others are green. |
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Feb 22, 2023
…odules (apache#24992) * Use "extensions/avro" instead of avro from"core" in Java SDK modules * Use "extensions/avro" instead of avro from"core" in sdks/java/io/kafka * Use "extensions/avro" instead of avro from"core" in sdks/java/io/google-cloud-platform * Resolve rebase conflicts * Use "extensions/avro" for Dataflow runner * Use "extensions/avro" for core-construction runner * Add avro extension as a dependency for direct runner * Copy Avro-related tests to Avro extension * Address review comments * Depend javaPreCommit on extensions:avro * Address review comments * Revert CountingSource.java * Up-to-date Avro usages
ruslan-ikhsan
pushed a commit
to akvelon/beam
that referenced
this pull request
Mar 10, 2023
…odules (apache#24992) * Use "extensions/avro" instead of avro from"core" in Java SDK modules * Use "extensions/avro" instead of avro from"core" in sdks/java/io/kafka * Use "extensions/avro" instead of avro from"core" in sdks/java/io/google-cloud-platform * Resolve rebase conflicts * Use "extensions/avro" for Dataflow runner * Use "extensions/avro" for core-construction runner * Add avro extension as a dependency for direct runner * Copy Avro-related tests to Avro extension * Address review comments * Depend javaPreCommit on extensions:avro * Address review comments * Revert CountingSource.java * Up-to-date Avro usages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make all Beam Java SDK modules, that depend on Avro, use Avro extension instead of Avro from
core.It should not introduce any breaking changes for users.
Closes #24748
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.