Gradle Build Optimizations #24764

clayburn · 2022-12-22T17:57:46Z

This change includes a few Gradle Build optimizations, including:

Updating to Gradle 7.6.1
Improving caching of the Checkstyle tasks

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

github-actions · 2022-12-22T18:35:31Z

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @apilloud for label java.
R: @damccorm for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

codecov · 2022-12-22T19:00:46Z

Codecov Report

Merging #24764 (2a07fa4) into master (967db6f) will increase coverage by 1.96%.
The diff coverage is n/a.

❗ Current head 2a07fa4 differs from pull request most recent head c032a38. Consider uploading reports for the commit c032a38 to get more accurate results

@@            Coverage Diff             @@
##           master   #24764      +/-   ##
==========================================
+ Coverage   70.94%   72.91%   +1.96%     
==========================================
  Files         861      746     -115     
  Lines      104795    99264    -5531     
==========================================
- Hits        74344    72374    -1970     
+ Misses      28894    25524    -3370     
+ Partials     1557     1366     -191

Flag	Coverage Δ
python	`82.38% <ø> (+2.37%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 434 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2022-12-30T12:13:33Z

Reminder, please take a look at this pr: @apilloud @damccorm

github-actions · 2023-01-04T12:13:54Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions · 2023-01-12T12:14:22Z

Reminder, please take a look at this pr: @robertwb @Abacn

github-actions · 2023-01-17T12:13:59Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @damccorm for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

github-actions · 2023-01-25T12:14:23Z

Reminder, please take a look at this pr: @kennknowles @damccorm

github-actions · 2023-01-27T12:15:56Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @lukecwik for label java.
R: @Abacn for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

kennknowles · 2023-02-01T21:28:56Z

Looks like a lot of tests are red. I didn't look into why, but it seems likely to do with this change?

github-actions · 2023-02-09T12:14:15Z

Reminder, please take a look at this pr: @lukecwik @Abacn

kennknowles · 2023-02-09T20:49:23Z

Some of the failures appear to be new intra-project dependency issues discovered by the upgrade to that analysis plugin. I suggest separating that upgrade from the gradle upgrade, if possible.

clayburn · 2023-02-10T13:46:18Z

@kennknowles Thanks for the feedback. I rebased yesterday but didn't get a chance to analyze the results. I've removed the analysis plugin update from this PR.

kennknowles · 2023-02-10T17:51:57Z

Run Java_GCP_IO_Direct PreCommit

kennknowles · 2023-02-10T17:52:21Z

Seeing enough green that I am optimistic. Kicking the test that had an NPE.

github-actions · 2023-02-18T12:14:04Z

Reminder, please take a look at this pr: @lukecwik @Abacn

clayburn · 2023-07-06T12:39:43Z

@damccorm apologies, I missed that this was merge conflicted. I've rebased the PR.

kennknowles · 2023-07-12T13:52:38Z

Run Java_Spark3_Versions PreCommit

kennknowles · 2023-07-12T13:52:45Z

Run Java_Spark3_Versions PreCommit

kennknowles · 2023-07-12T13:58:24Z

run java precommit

github-actions · 2023-07-20T12:14:03Z

Reminder, please take a look at this pr: @robertwb @damccorm

github-actions · 2023-07-25T12:14:26Z

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @Abacn for label build.

Available commands:

stop reviewer notifications - opt out of the automated review tooling
remind me after tests pass - tag the comment author after tests pass
waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

damccorm · 2023-07-25T13:45:56Z

R: @kennknowles

damccorm · 2023-07-25T13:45:59Z

(could you take this one to completion since you've started reviewing?)

github-actions · 2023-07-25T13:47:24Z

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

kennknowles · 2023-07-25T14:03:49Z

Ha! If by "started review" you mean "kicked the tests" :-p

kennknowles · 2023-07-25T14:04:48Z

Everything is green now but we have to resolve the conflicts.

As configured before, the `configProperties` field has an absolute path sensitivity introduced by the reference to the suppressions file. This change causes the path to be relative to the project root, which can facilitate cache hits when absolute paths change (for example, when the build is run from a CI system and a remote cache is populated, then consumed from a local build). This refactoring matches recommendations found in the Gradle documentation for structuring Checkstyle configuration files: https://docs.gradle.org/current/userguide/checkstyle_plugin.html#sec:checkstyle_built_in_variables This change also configure Checkstyle via the `CheckstyleExtension` rather than the `Checkstyle` tasks

clayburn · 2023-07-25T14:54:53Z

@kennknowles, the conflicts should now be resolved ✅

kennknowles · 2023-07-25T18:13:09Z

Filed #27666 for the Kinesis failure.

Filed #27667 for the Python coverage failure.

kennknowles · 2023-07-25T18:13:20Z

Run Python_Coverage PreCommit

kennknowles · 2023-07-25T18:13:51Z

Run Java_Amazon-Web-Services2_IO_Direct Precommit

Abacn · 2023-07-25T19:17:22Z

Run Java_PVR_Flink_Batch PreCommit

kennknowles · 2023-07-26T15:29:41Z

Green. Hooray!

github-actions bot added build java labels Dec 22, 2022

github-actions bot added the Next Action: Reviewers label Dec 22, 2022

github-actions bot added the slow-review label Dec 30, 2022

github-actions bot removed the slow-review label Jan 4, 2023

github-actions bot added the slow-review label Jan 12, 2023

github-actions bot removed the slow-review label Jan 17, 2023

github-actions bot added the slow-review label Jan 25, 2023

github-actions bot removed the slow-review label Jan 27, 2023

github-actions bot added the slow-review label Feb 9, 2023

clayburn force-pushed the gradle-optimizations branch from a6357da to 2a07fa4 Compare February 9, 2023 13:41

clayburn closed this Feb 9, 2023

clayburn reopened this Feb 9, 2023

github-actions bot removed the slow-review label Feb 10, 2023

clayburn force-pushed the gradle-optimizations branch from 2a07fa4 to 639b3b3 Compare February 10, 2023 13:45

damccorm added Next Action: Author and removed Next Action: Reviewers slow-review labels Jul 5, 2023

clayburn force-pushed the gradle-optimizations branch from 79e2d15 to fc6d9eb Compare July 6, 2023 12:38

github-actions bot added Next Action: Reviewers and removed Next Action: Author labels Jul 6, 2023

github-actions bot added the slow-review label Jul 20, 2023

github-actions bot removed the slow-review label Jul 25, 2023

clayburn added 2 commits July 25, 2023 09:53

Update Gradle Wrapper to 7.6.2

42393ba

clayburn force-pushed the gradle-optimizations branch from fc6d9eb to c032a38 Compare July 25, 2023 14:54

kennknowles merged commit c754e58 into apache:master Jul 26, 2023

clayburn deleted the gradle-optimizations branch July 27, 2023 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gradle Build Optimizations #24764

Gradle Build Optimizations #24764

clayburn commented Dec 22, 2022 •

edited

Loading

github-actions bot commented Dec 22, 2022

codecov bot commented Dec 22, 2022 •

edited

Loading

github-actions bot commented Dec 30, 2022

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 17, 2023

github-actions bot commented Jan 25, 2023

github-actions bot commented Jan 27, 2023

kennknowles commented Feb 1, 2023

github-actions bot commented Feb 9, 2023

kennknowles commented Feb 9, 2023

clayburn commented Feb 10, 2023

kennknowles commented Feb 10, 2023

kennknowles commented Feb 10, 2023

github-actions bot commented Feb 18, 2023

clayburn commented Jul 6, 2023

kennknowles commented Jul 12, 2023

kennknowles commented Jul 12, 2023

kennknowles commented Jul 12, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 25, 2023

damccorm commented Jul 25, 2023

damccorm commented Jul 25, 2023

github-actions bot commented Jul 25, 2023

kennknowles commented Jul 25, 2023

kennknowles commented Jul 25, 2023

clayburn commented Jul 25, 2023

kennknowles commented Jul 25, 2023

kennknowles commented Jul 25, 2023

kennknowles commented Jul 25, 2023

Abacn commented Jul 25, 2023

kennknowles commented Jul 26, 2023

Gradle Build Optimizations #24764

Gradle Build Optimizations #24764

Conversation

clayburn commented Dec 22, 2022 • edited Loading

GitHub Actions Tests Status (on master branch)

github-actions bot commented Dec 22, 2022

codecov bot commented Dec 22, 2022 • edited Loading

Codecov Report

github-actions bot commented Dec 30, 2022

github-actions bot commented Jan 4, 2023

github-actions bot commented Jan 12, 2023

github-actions bot commented Jan 17, 2023

github-actions bot commented Jan 25, 2023

github-actions bot commented Jan 27, 2023

kennknowles commented Feb 1, 2023

github-actions bot commented Feb 9, 2023

kennknowles commented Feb 9, 2023

clayburn commented Feb 10, 2023

kennknowles commented Feb 10, 2023

kennknowles commented Feb 10, 2023

github-actions bot commented Feb 18, 2023

clayburn commented Jul 6, 2023

kennknowles commented Jul 12, 2023

kennknowles commented Jul 12, 2023

kennknowles commented Jul 12, 2023

github-actions bot commented Jul 20, 2023

github-actions bot commented Jul 25, 2023

damccorm commented Jul 25, 2023

damccorm commented Jul 25, 2023

github-actions bot commented Jul 25, 2023

kennknowles commented Jul 25, 2023

kennknowles commented Jul 25, 2023

clayburn commented Jul 25, 2023

kennknowles commented Jul 25, 2023

kennknowles commented Jul 25, 2023

kennknowles commented Jul 25, 2023

Abacn commented Jul 25, 2023

kennknowles commented Jul 26, 2023

clayburn commented Dec 22, 2022 •

edited

Loading

codecov bot commented Dec 22, 2022 •

edited

Loading