Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Normalize Beam YAML PubSub format to uppercase #31067

Closed
2 of 16 tasks
ffernandez92 opened this issue Apr 22, 2024 · 3 comments
Closed
2 of 16 tasks

[Task]: Normalize Beam YAML PubSub format to uppercase #31067

ffernandez92 opened this issue Apr 22, 2024 · 3 comments

Comments

@ffernandez92
Copy link
Contributor

What needs to happen?

The current PubSub YAML implementation has the format option in lowercase. However, Kafka and PubSub Lite have it in uppercase. I'd like to change the current PubSub one to accept uppercase and grandfather in the existing uses.

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@ffernandez92
Copy link
Contributor Author

.take-issue

@ffernandez92
Copy link
Contributor Author

@robertwb what do you think about the PR? It aims to standardize the uppercase-lowercase issue with PubSub (Since Kafka and PSL use uppercase). For now, it will accept both until we're ready to deprecate the lowercase one. I've already implemented a warning log for the usage of lowercase

cc: @brucearctor

@github-actions github-actions bot added this to the 2.57.0 Release milestone Apr 23, 2024
@brucearctor
Copy link
Contributor

Marking as closed. There is likely an eventual follow up task to actually standardize, instead of allowing both. But, can revisit that in MANY versions from now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants