Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo spark_runner exclude test #30589

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Redo spark_runner exclude test #30589

merged 1 commit into from
Mar 11, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Mar 8, 2024

This test was excluded in #30030. However, the change was later reverted in f73ce82#diff-005880cee144b69c4a7a7ff12b65497a75a41011570c1585fc9eced3e2c73323 likely unintended rebase error

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@Abacn
Copy link
Contributor Author

Abacn commented Mar 8, 2024

R: @shunping @kennknowles

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@Abacn
Copy link
Contributor Author

Abacn commented Mar 11, 2024

R: @damccorm (#30586 (comment))

@shunping
Copy link
Contributor

LGTM

@Abacn Abacn merged commit 792cecb into apache:master Mar 11, 2024
16 checks passed
@Abacn Abacn deleted the readd branch March 11, 2024 17:21
Abacn added a commit to Abacn/beam that referenced this pull request Mar 11, 2024
Abacn added a commit that referenced this pull request Mar 11, 2024
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants