Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flag for direct path that reads from system properties #30588

Merged
merged 5 commits into from
Mar 14, 2024
Merged

add flag for direct path that reads from system properties #30588

merged 5 commits into from
Mar 14, 2024

Conversation

m-trieu
Copy link
Contributor

@m-trieu m-trieu commented Mar 8, 2024 •
edited by tvalentyn
Loading

to manage rolling out of direct path

will not work if:

  • direct path is not enabled in streaming backend
  • VMs setting this flag are not using IPv6

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn added as fallback since no labels match configuration

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@tvalentyn
Copy link
Contributor

R: @arunpandianp

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

arunpandianp
arunpandianp reviewed Mar 11, 2024
View reviewed changes
...src/main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java Outdated
@Description(
"If true, Dataflow streaming pipeline will be running in direct path mode."
+ " VMs must have IPv6 enabled for this to work.")
@Default.InstanceFactory(IsWindmillServiceDirectPathEnabled.class)
Copy link
Contributor

@arunpandianp arunpandianp Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need the factory IsWindmillServiceDirectPathEnabled. Can directly pass --windmillServiceDirectPathEnabled=true when needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack ok

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@m-trieu
Copy link
Contributor Author

m-trieu commented Mar 14, 2024

@tvalentyn ready to merge! thanks

@tvalentyn tvalentyn merged commit 49c7864 into apache:master Mar 14, 2024
17 checks passed
@tvalentyn
Copy link
Contributor

note: @scwhittle can also merge and might have more context on streaming DF worker aspects.

scwhittle
scwhittle reviewed Mar 19, 2024
View reviewed changes
...src/main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java
@Default.Boolean(false)
boolean getIsWindmillServiceDirectPathEnabled();

void setIsWindmillServiceDirectPathEnabled(boolean isWindmillServiceDirectPathEnabled);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the is, otherwise specifying the flag looks odd IMO
--isWindmillServiceDirectPathEnabled=true

hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
@m-trieu @hjtran
add flag for direct path that reads from system properties (apache#30588
260a143 
)

* add flag for direct path that reads from system properties

* remove unused imports

* change flag name to something more unique

* remove instance factory and just use boolean

* fix option name format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scwhittle scwhittle scwhittle left review comments

@arunpandianp arunpandianp arunpandianp approved these changes

Assignees
No one assigned
Labels
dataflow Next Action: Reviewers runners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-trieu @tvalentyn @arunpandianp @scwhittle