Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action workflows to mass_commit #28665

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Sep 26, 2023

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label Sep 26, 2023
@Abacn
Copy link
Contributor Author

Abacn commented Sep 26, 2023

R: @damccorm

@Abacn
Copy link
Contributor Author

Abacn commented Sep 26, 2023

CC: @kennknowles

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #28665 (2ebe52f) into master (042ac52) will decrease coverage by 0.35%.
Report is 56 commits behind head on master.
The diff coverage is 33.87%.

@@            Coverage Diff             @@
##           master   #28665      +/-   ##
==========================================
- Coverage   72.31%   71.97%   -0.35%     
==========================================
  Files         684      680       -4     
  Lines      101727   100169    -1558     
==========================================
- Hits        73567    72093    -1474     
+ Misses      26581    26498      -83     
+ Partials     1579     1578       -1     
Flag Coverage Δ
python 82.54% <33.87%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pache_beam/dataframe/pandas_top_level_functions.py 90.62% <100.00%> (+0.33%) ⬆️
sdks/python/apache_beam/io/gcp/bigtableio.py 74.04% <ø> (-0.96%) ⬇️
sdks/python/apache_beam/typehints/schemas.py 88.91% <100.00%> (-2.71%) ⬇️
sdks/python/apache_beam/version.py 100.00% <100.00%> (ø)
sdks/python/apache_beam/io/gcp/bigquery.py 69.92% <50.00%> (-0.25%) ⬇️
sdks/python/apache_beam/yaml/yaml_provider.py 64.31% <25.92%> (-7.83%) ⬇️

... and 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennknowles
Copy link
Member

Side comment on all this: can we make the name of each workflow exactly the command to re-run it, and also exactly the command to run it locally (if possible)?

@Abacn
Copy link
Contributor Author

Abacn commented Sep 26, 2023

Side comment on all this: can we make the name of each workflow exactly the command to re-run it, and also exactly the command to run it locally (if possible)?

Yes we should cleanup namings jobs are all migrated. Currently the phrases are just kept to be the same as original Jenkins phrase

@Abacn
Copy link
Contributor Author

Abacn commented Sep 26, 2023

R: @kennknowles PTAL

@Abacn
Copy link
Contributor Author

Abacn commented Sep 27, 2023

mass commit is working - #28698

@kennknowles kennknowles merged commit 84b9336 into apache:master Oct 6, 2023
65 of 66 checks passed
@Abacn Abacn deleted the addtomasscommit branch October 6, 2023 19:25
kennknowles pushed a commit to kennknowles/beam that referenced this pull request Oct 6, 2023
kennknowles added a commit that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants