Remove append method for Pandas >= 2.0. #28396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas removed .append in 2.0 so this helps keep the API consistent.
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov Report
@@ Coverage Diff @@
## master #28396 +/- ##
=======================================
Coverage 72.32% 72.33%
=======================================
Files 683 683
Lines 100620 100643 +23
=======================================
+ Hits 72776 72798 +22
- Misses 26266 26267 +1
Partials 1578 1578
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tvalentyn
reviewed
Sep 11, 2023
tvalentyn
reviewed
Sep 12, 2023
caneff
force-pushed
the
remove_append
branch
from
70bfb95 to
3ed2822
Compare
caneff
force-pushed
the
remove_append
branch
from
3ed2822 to
fb38399
Compare
tvalentyn
reviewed
Sep 13, 2023
|
Run PythonDocker PreCommit |
|
(that was a test trigger command) |
|
Run PythonDocker PreCommit 3.11 |
tvalentyn
approved these changes
Sep 13, 2023
This reverts commit 69df894.
tvalentyn
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas removed .append in 2.0 so this helps keep the API consistent.
Requires adding new functionality to the decorators to conditionally skip them.
Partially fixing #27221