Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update concurrency group definition #28373

Merged
merged 2 commits into from
Sep 9, 2023

Conversation

volatilemolotov
Copy link
Contributor

Adds comment body to concurrency group definition to prevent different PRs canceling other jobs.
Fixes part of: #28320

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@volatilemolotov
Copy link
Contributor Author

R: @Abacn

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn
Copy link
Contributor

Abacn commented Sep 8, 2023

ah it's still in draft status (and looks good for me)

@volatilemolotov volatilemolotov marked this pull request as ready for review September 8, 2023 17:40
@volatilemolotov
Copy link
Contributor Author

@Abacn Yeah i left in in draft until confirmation. Its ready now.

@Abacn Abacn merged commit f86d9e2 into apache:master Sep 9, 2023
@volatilemolotov
Copy link
Contributor Author

@Abacn @damccorm Seems like this is causing issues of perpetually queued jobs somehow. Could be connected to some Actions outage which would explain the first queued job getting stuck but all further are considered the same group somehow. Think the issue is the body of comment :

https://github.com/apache/beam/actions/workflows/beam_PerformanceTests_BigQueryIO_Batch_Java_Json.yml?query=is%3Aqueued

and looking at the first job trigger we get to #28272 (comment)
which is a multiline comment with code embedded and that might be causing the group to be broken somehow.

Should we perhaps use comment id or something https://docs.github.com/en/webhooks/webhook-events-and-payloads#issue_comment

@Abacn
Copy link
Contributor

Abacn commented Sep 21, 2023

fair - let's use comment id

@volatilemolotov volatilemolotov deleted the concurrency_groups_new branch September 25, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants