-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: GitHub Action Phrase Issues #28320
Comments
Current status
Example PR displaying these issues: #28316 |
Seems like we need to think about the PostCommit nature to solve it correctly. Not sure at this point what is the best option but ill take the issue and report what is going on and how to continue. |
.take-issue |
Ok so the first issue
Is due to concurrency groups added:
It can be fixed by adding ${{ github.event.schedule || github.event.comment.created_at }} in the final part. Note that schedule event does not affect this because there is OR in the expression. @Abacn let me know what you think would be the preferred approach. |
Thanks, github.event.comment.body sounds good. Does "irrelevant comment will cancel the previous one" mean Update: did another experimental: https://github.com/apache/beam/actions/runs/6101642034 The current group name is 'PreCommit Whitespace @ 9954d3e-Abacn-' If add "github.event.comment.body", it won't be cancelled by irrelevant comment, but it can still be cancelled by the same comment in another irrelevant PR (saying I opened two PRs and use the same phrase trigger). Let me also think a little bit what it should be |
how about '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body }}' ? this is because the second part ${{ github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }} is observed to be always head sha for pull request; and we do not care about sender - just same PR should have only one run on one workflow per https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#issue_comment-on-issues-only-or-pull-requests-only - ${{ github.event.issue.number }} is available in issue_comment event |
${{ github.event.sender.login }} is needed for dispatch |
Then how about |
Created a draft: #28373 |
What happened?
Create a persistent issue for GitHub Action phrase implementations. Update the current status in comments below
Issue Priority
Priority: 2 (default / most bugs should be filed as P2)
Issue Components
The text was updated successfully, but these errors were encountered: