Skip calling Compute in RemoveSafeDeltaCounterCell if value exists (#…

…30913) * Skip calling Compute in RemoveSafeDeltaCounterCell if value already exists * Address comments
apache · Apr 16, 2024 · ec31847 · ec31847
1 parent ae597cc
commit ec31847
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/...ker/src/main/java/org/apache/beam/runners/dataflow/worker/RemoveSafeDeltaCounterCell.java b/...ker/src/main/java/org/apache/beam/runners/dataflow/worker/RemoveSafeDeltaCounterCell.java
@@ -62,15 +62,12 @@ public void reset() {
 
   @Override
   public void inc(long n) {
-    countersMap.compute(
-        metricName,
-        (name, value) -> {
-          if (value == null) {
-            return new AtomicLong(n);
-          }
-          value.addAndGet(n);
-          return value;
-        });
+    AtomicLong val = countersMap.get(metricName);
+    if (val != null) {
+      val.getAndAdd(n);
+      return;
+    }
+    countersMap.computeIfAbsent(metricName, name -> new AtomicLong()).getAndAdd(n);
   }
 
   @Override