Fix exception sampling logic (#33076)

* Fix exception sampling logic * Allow subclasses of BaseException * Mock cython if not present * Use correct types/names * format
apache · Nov 11, 2024 · c6549e7 · c6549e7
1 parent 47740d0
commit c6549e7
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/sdks/python/apache_beam/runners/common.py b/sdks/python/apache_beam/runners/common.py
@@ -1504,8 +1504,7 @@ def process(self, windowed_value):
       return []
 
   def _maybe_sample_exception(
-      self, exn: BaseException,
-      windowed_value: Optional[WindowedValue]) -> None:
+      self, exc_info: Tuple, windowed_value: Optional[WindowedValue]) -> None:
 
     if self.execution_context is None:
       return
@@ -1516,7 +1515,7 @@ def _maybe_sample_exception(
 
     output_sampler.sample_exception(
         windowed_value,
-        exn,
+        exc_info,
         self.transform_id,
         self.execution_context.instruction_id)