Delete on exit beam-artifact temp file (#29219)

apache · Oct 31, 2023 · a036a18 · a036a18
1 parent e2a7ea6
commit a036a18
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/...e-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java b/...e-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java
@@ -19,6 +19,7 @@
 
 import static org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkArgument;
 
+import java.io.File;
 import java.io.FileOutputStream;
 import java.io.IOException;
 import java.nio.file.Files;
@@ -391,7 +392,8 @@ private static List<RunnerApi.ArtifactInformation> resolveArtifacts(
                       .build())
               .getReplacementsList()) {
         Path path = Files.createTempFile("beam-artifact", "");
-        try (FileOutputStream fout = new FileOutputStream(path.toFile())) {
+        File artifactFile = path.toFile();
+        try (FileOutputStream fout = new FileOutputStream(artifactFile)) {
           for (Iterator<ArtifactApi.GetArtifactResponse> it =
                   retrievalStub.getArtifact(
                       ArtifactApi.GetArtifactRequest.newBuilder().setArtifact(artifact).build());
@@ -409,6 +411,8 @@ private static List<RunnerApi.ArtifactInformation> resolveArtifacts(
                         .build()
                         .toByteString())
                 .build());
+        // Delete beam-artifact temp File on program exit
+        artifactFile.deleteOnExit();
       }
       return resolved;
     }