-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add Pubsub lite write metrics and DLQ support (#26482)
* init * fixup * no data being processed. debugging * added element counter * only error counter and dlq. Removed element counter * add unit test * change name * resolve conflicts
- Loading branch information
1 parent
f70e9bf
commit 86f56e9
Showing
2 changed files
with
154 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
.../src/test/java/org/apache/beam/sdk/io/gcp/pubsublite/internal/PubsubLiteWriteDlqTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.io.gcp.pubsublite.internal; | ||
|
|
||
| import com.google.cloud.pubsublite.proto.PubSubMessage; | ||
| import com.google.protobuf.ByteString; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import org.apache.beam.sdk.io.gcp.pubsublite.PubsubLiteWriteSchemaTransformProvider; | ||
| import org.apache.beam.sdk.io.gcp.pubsublite.PubsubLiteWriteSchemaTransformProvider.ErrorCounterFn; | ||
| import org.apache.beam.sdk.schemas.Schema; | ||
| import org.apache.beam.sdk.schemas.utils.JsonUtils; | ||
| import org.apache.beam.sdk.testing.PAssert; | ||
| import org.apache.beam.sdk.testing.TestPipeline; | ||
| import org.apache.beam.sdk.transforms.Create; | ||
| import org.apache.beam.sdk.transforms.ParDo; | ||
| import org.apache.beam.sdk.transforms.SerializableFunction; | ||
| import org.apache.beam.sdk.values.PCollection; | ||
| import org.apache.beam.sdk.values.PCollectionTuple; | ||
| import org.apache.beam.sdk.values.Row; | ||
| import org.apache.beam.sdk.values.TupleTag; | ||
| import org.apache.beam.sdk.values.TupleTagList; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public class PubsubLiteWriteDlqTest { | ||
|
|
||
| private static final TupleTag<PubSubMessage> OUTPUT_TAG = | ||
| PubsubLiteWriteSchemaTransformProvider.OUTPUT_TAG; | ||
| private static final TupleTag<Row> ERROR_TAG = PubsubLiteWriteSchemaTransformProvider.ERROR_TAG; | ||
|
|
||
| private static final Schema BEAMSCHEMA = | ||
| Schema.of(Schema.Field.of("name", Schema.FieldType.STRING)); | ||
| private static final Schema ERRORSCHEMA = PubsubLiteWriteSchemaTransformProvider.ERROR_SCHEMA; | ||
|
|
||
| private static final List<Row> ROWS = | ||
| Arrays.asList( | ||
| Row.withSchema(BEAMSCHEMA).withFieldValue("name", "a").build(), | ||
| Row.withSchema(BEAMSCHEMA).withFieldValue("name", "b").build(), | ||
| Row.withSchema(BEAMSCHEMA).withFieldValue("name", "c").build()); | ||
|
|
||
| private static final List<PubSubMessage> MESSAGES = | ||
| Arrays.asList( | ||
| PubSubMessage.newBuilder().setData(ByteString.copyFromUtf8("{\"name\":\"a\"}")).build(), | ||
| PubSubMessage.newBuilder().setData(ByteString.copyFromUtf8("{\"name\":\"b\"}")).build(), | ||
| PubSubMessage.newBuilder().setData(ByteString.copyFromUtf8("{\"name\":\"c\"}")).build()); | ||
|
|
||
| final SerializableFunction<Row, byte[]> valueMapper = | ||
| JsonUtils.getRowToJsonBytesFunction(BEAMSCHEMA); | ||
|
|
||
| @Rule public transient TestPipeline p = TestPipeline.create(); | ||
|
|
||
| @Test | ||
| public void testPubsubLiteErrorFnSuccess() throws Exception { | ||
| PCollection<Row> input = p.apply(Create.of(ROWS)); | ||
| PCollectionTuple output = | ||
| input.apply( | ||
| ParDo.of(new ErrorCounterFn("ErrorCounter", valueMapper)) | ||
| .withOutputTags(OUTPUT_TAG, TupleTagList.of(ERROR_TAG))); | ||
|
|
||
| output.get(ERROR_TAG).setRowSchema(ERRORSCHEMA); | ||
|
|
||
| PAssert.that(output.get(OUTPUT_TAG)).containsInAnyOrder(MESSAGES); | ||
| p.run().waitUntilFinish(); | ||
| } | ||
| } |