Revert "Set setFailIfPoolExhausted in SessionPoolOptions for SpannerA…

…ccessor" (#32694) (#32702) This reverts commit efee92b. Co-authored-by: Manit Gupta <[email protected]>
apache · Oct 8, 2024 · 64854bb · 64854bb
1 parent 8eef4a3
commit 64854bb
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/...ogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java b/...ogle-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessor.java
@@ -30,7 +30,6 @@
 import com.google.cloud.spanner.DatabaseAdminClient;
 import com.google.cloud.spanner.DatabaseClient;
 import com.google.cloud.spanner.DatabaseId;
-import com.google.cloud.spanner.SessionPoolOptions;
 import com.google.cloud.spanner.Spanner;
 import com.google.cloud.spanner.SpannerOptions;
 import com.google.cloud.spanner.v1.stub.SpannerStubSettings;
@@ -233,9 +232,7 @@ static SpannerOptions buildSpannerOptions(SpannerConfig spannerConfig) {
     if (credentials != null && credentials.get() != null) {
       builder.setCredentials(credentials.get());
     }
-    SessionPoolOptions sessionPoolOptions =
-        SessionPoolOptions.newBuilder().setFailIfPoolExhausted().build();
-    builder.setSessionPoolOption(sessionPoolOptions);
+
     return builder.build();
   }
 

diff --git a/...-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java b/...-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerAccessorTest.java
@@ -18,7 +18,6 @@
 package org.apache.beam.sdk.io.gcp.spanner;
 
 import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
 import static org.mockito.ArgumentMatchers.eq;
 import static org.mockito.Mockito.times;
 import static org.mockito.Mockito.verify;
@@ -164,6 +163,5 @@ public void testBuildSpannerOptionsWithCredential() {
     assertEquals("project", options.getProjectId());
     assertEquals("test-role", options.getDatabaseRole());
     assertEquals(testCredential, options.getCredentials());
-    assertNotNull(options.getSessionPoolOptions());
   }
 }