Skip to content

Commit

Permalink
Undo changes to BeamModulePlugin.groovy (#28356)
Browse files Browse the repository at this point in the history
  • Loading branch information
damccorm authored Sep 7, 2023
1 parent b35ad6d commit 5bf6fbf
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/beam_Release_NightlySnapshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ jobs:
</settings>" > ${HOME}/.m2/settings.xml
- name: run Publish script
run: |
./gradlew publish --max-workers=8 -Ppublishing -PskipCheckerFramework -PisNightly \
./gradlew publish --max-workers=8 -Ppublishing -PskipCheckerFramework \
--continue -Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx6g \
-Dorg.gradle.vfs.watch=false -Pdocker-pull-licenses
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,6 @@ class BeamModulePlugin implements Plugin<Project> {
def isRelease(Project project) {
return parseBooleanProperty(project, 'isRelease');
}
def isNightly(Project project) {
return parseBooleanProperty(project, 'isNightly');
}
/**
* Parses -Pprop as true for use as a flag, and otherwise uses Groovy's toBoolean
*/
Expand Down Expand Up @@ -492,14 +489,10 @@ class BeamModulePlugin implements Plugin<Project> {

project.ext.mavenGroupId = 'org.apache.beam'

if (isRelease(project) && isNightly(project)) {
throw new GradleException("Cannot specify both -PisRelease and -PisNightly properties")
}
if (isNightly(project)) {
Date date = new Date()
project.version += "-" + date.format('yyyyMMdd')
}
else if (!isRelease(project)) {
// Automatically use the official release version if we are performing a release
// otherwise append '-SNAPSHOT'
project.version = '2.51.0'
if (!isRelease(project)) {
project.version += '-SNAPSHOT'
}

Expand Down

0 comments on commit 5bf6fbf

Please sign in to comment.