dont swallow errors (#32946)

apache · Oct 25, 2024 · 2dfa281 · 2dfa281
1 parent 3cc2909
commit 2dfa281
Showing 1 changed file with 9 additions and 13 deletions.
diff --git a/...cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteBundlesToFiles.java b/...cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteBundlesToFiles.java
@@ -297,19 +297,15 @@ public void finishBundle(FinishBundleContext c) throws Exception {
     }
 
     for (Map.Entry<DestinationT, BigQueryRowWriter<ElementT>> entry : writers.entrySet()) {
-      try {
-        DestinationT destination = entry.getKey();
-        BigQueryRowWriter<ElementT> writer = entry.getValue();
-        BigQueryRowWriter.Result result = writer.getResult();
-        BoundedWindow window = writerWindows.get(destination);
-        Preconditions.checkStateNotNull(window);
-        c.output(
-            new Result<>(result.resourceId.toString(), result.byteSize, destination),
-            window.maxTimestamp(),
-            window);
-      } catch (Exception e) {
-        exceptionList.add(e);
-      }
+      DestinationT destination = entry.getKey();
+      BigQueryRowWriter<ElementT> writer = entry.getValue();
+      BigQueryRowWriter.Result result = writer.getResult();
+      BoundedWindow window = writerWindows.get(destination);
+      Preconditions.checkStateNotNull(window);
+      c.output(
+          new Result<>(result.resourceId.toString(), result.byteSize, destination),
+          window.maxTimestamp(),
+          window);
     }
     writers.clear();
   }