GH-42116: [C++] Support list-view typed arrays in array_take and array_filter #42117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: C++
awaiting committer review
FILE SIZE VM SIZE
-------------- --------------
[NEW] +318 [NEW] +164 __ZNSt3__120__shared_ptr_emplaceIN5arrow12BooleanArrayENS_9allocatorIS2_EEEC1B8ue170006IJxRKNS_10shared_ptrINS1_6BufferEEEDnixEEES4_DpOT_
[NEW] +201 [NEW] +40 __ZNSt3__120__shared_ptr_emplaceIN5arrow12BooleanArrayENS_9allocatorIS2_EEEC1B8ue170006IJxRKNS_10shared_ptrINS1_6BufferEEEDnixEEES4_DpOT_.cold.1
[DEL] -200 [DEL] -40 __ZNSt3__120__shared_ptr_emplaceIN5arrow12BooleanArrayENS_9allocatorIS2_EEEC1B8ue170006IJxRNS_10shared_ptrINS1_6BufferEEEDnixEEES4_DpOT_.cold.1
[DEL] -264 [DEL] -184 arrow::Result<std::__1::shared_ptr<arrow::BooleanArray> >::~Result()
-22.1% -264 -24.7% -264 arrow::compute::internal::(anonymous namespace)::DropNullArray(std::__1::shared_ptr<arrow::Array> const&, arrow::compute::ExecContext*)
[DEL] -317 [DEL] -164 __ZNSt3__120__shared_ptr_emplaceIN5arrow12BooleanArrayENS_9allocatorIS2_EEEC1B8ue170006IJxRNS_10shared_ptrINS1_6BufferEEEDnixEEES4_DpOT_
-0.5% -680 -0.8% -496 TOTAL
felipecrv
force-pushed
the
list_view_take
branch
from
2532f7d to
c11a6d1
Compare
|
Is it worth reviewing this before #41700 gets merged and rebased upon? |
pitrou
reviewed
Jun 27, 2024
It is. I would like to merge any one of the PRs as soon as I can. Rebasing either way won't be hard. |
github-actions
bot
added
awaiting changes
pitrou
approved these changes
Jun 27, 2024
github-actions
bot
added
awaiting change review
pitrou
approved these changes
Jun 27, 2024
|
CI failures are related to ORC. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62ee676. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 31 possible false positives for unstable benchmarks that are known to sometimes produce them. |
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Jul 9, 2024
…d array_filter (apache#42117) ### Rationale for this change Completing the type coverage in array_take and array_filter. ### What changes are included in this PR? Add support for `ListView` and `LargeListView` in `"array_take"`, `"array_filter"` and all the functions that indirectly rely on these to do their thing. ### Are these changes tested? New test cases were added. * GitHub Issue: apache#42116 Authored-by: Felipe Oliveira Carvalho <[email protected]> Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Completing the type coverage in array_take and array_filter.
What changes are included in this PR?
Add support for
ListViewandLargeListViewin"array_take","array_filter"and all the functions that indirectly rely on these to do their thing.Are these changes tested?
New test cases were added.