[Java] Remove use of jsr305 #43396
Comments
laurentgo
added a commit
to laurentgo/arrow
that referenced
this issue
Jul 23, 2024
jsr305 is not maintained anymore and is unlikely to support JPMS. The classes are also in the javax. namespace which is known to cause issues as well. Replace most uses of jsr305 with the equivalent checker framework annotations, and remove usage of @threadsafe.
laurentgo
added a commit
to laurentgo/arrow
that referenced
this issue
Jul 23, 2024
jsr305 is not maintained anymore and is unlikely to support JPMS. The classes are also in the javax. namespace which is known to cause issues as well. Replace most uses of jsr305 with the equivalent checker framework annotations, and remove usage of @threadsafe.
laurentgo
added a commit
to laurentgo/arrow
that referenced
this issue
Jul 23, 2024
jsr305 is not maintained anymore and is unlikely to support JPMS. The classes are also in the javax. namespace which is known to cause issues as well. Replace most uses of jsr305 with the equivalent checker framework annotations, and remove usage of @threadsafe.
lidavidm
pushed a commit
that referenced
this issue
Jul 24, 2024
### Rationale for this change jsr305 is not maintained anymore and is unlikely to support JPMS. The classes are also in the javax. namespace which is known to cause issues as well. ### What changes are included in this PR? Replace most uses of jsr305 with the equivalent checker framework annotations, and remove usage of `@ ThreadSafe.` ### Are these changes tested? CI/CD ### Are there any user-facing changes? None * GitHub Issue: #43396 Authored-by: Laurent Goujon <[email protected]> Signed-off-by: David Li <[email protected]>
|
Issue resolved by pull request 43397 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the enhancement requested
jsr305 dependency was an attempt at standardizing a set of annotations to provide semantic information regarding Java classes, methods, fields, etc.
Unfortunately the adoption has not been widespread and the dependency is not being updated, potentially causing issues with JPMS.
As some of the jsr305 annotations have equivalent within the checker framework, we could replace most of the usage of jsr305 annotations with checker annotations. The only one with no equivalent is
@ThreadSafewhich is only used once and could be simply removed.Note that the same discussion is happening in multiple projects, like caffeine or guava. There is also a new standardization project named jspecify but the project only provides 4 nullability correctness annotations for now while Arrow also uses checker framework beyond just nullability correctness.
Component(s)
Java
The text was updated successfully, but these errors were encountered: